Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting device name to custom string #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boltgolt
Copy link
Contributor

@boltgolt boltgolt commented Oct 17, 2023

When iSponsorBlockTV connects to the app the tv displays a notification that a "new device has joined", this PR makes the name that shows in that notification configurable. This is helpful for setting a more friendly name, especially handy if you have people on the network that do not know what "iSponsorBlockTV" means

@dmunozv04
Copy link
Owner

This is a good PR, but the use of device_name as a parameter could be confusing to users.

@boltgolt
Copy link
Contributor Author

Good point, what about join_name or self_description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants