Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: openweathermap api 요청 시 반환 dto 필드를 camel case로 수정 #207

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix: openweathermap api 요청 시 반환 dto 필드를 camel case로 수정 #207

merged 1 commit into from
Sep 18, 2024

Conversation

Jaewon-pro
Copy link
Member

🔗 이슈 연결

🚀 구현한 API

  • x

💡 반영할 내용 및 변경 사항 요약

  • openweathermap api 요청 시 반환 dto 필드를 camel case로 수정합니다.
    • feels_like -> feelsLike
    • temp_min -> tempMin
    • temp_max -> tempMax

🔍 리뷰 요청/참고 사항

@Jaewon-pro Jaewon-pro self-assigned this Sep 18, 2024
hee9841
hee9841 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@hee9841 hee9841 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@Jaewon-pro Jaewon-pro merged commit 79549ed into main Sep 18, 2024
1 check passed
@Jaewon-pro Jaewon-pro deleted the feature/#204/camel-json-field branch September 18, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hee9841 hee9841 hee9841 approved these changes

Assignees

@Jaewon-pro Jaewon-pro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openweathermap api에서 반환하는 response dto 필드를 camel case로 변경
2 participants
@Jaewon-pro @hee9841