[feat #177] 질문 글 작성 응답 DTO 잔여 크레딧 추가 #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@hyun2371 개발/운영서버 이분화에 따른 개발/운영 브랜치 이분화도 필요할 것 같습니다! |
Code Coverage
|
Test Results 28 files 28 suites 14s ⏱️ Results for commit 13212ba. |
hyun2371
approved these changes
Jan 1, 2025
prod 브랜치 생성했습니다! 주기적으로 dev->prod pr 올려서 배포하면 될 것 같아요 |
단순 credit을 하려다가 잔여 크레딧 표시에 쓰는 데이터다보니 remainingCredit으로 했었어요. 다른 곳은 쓰이는 기능에 맞게 네이밍하는게 좋을 것 같아요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
📑 작업 상세 내용
-
toRegisterQuestionPostResponse()의Member member = questionPost.getMember()을 이용한 credit 조회 시 변경감지 적용 전으로 인해 잔여 크레딧 정합성 오류 발생 -> 실제 크레딧이 차감된 Member를 직접 파라미터로 넘겨서 사용하도록 변경💫 작업 요약
🔍 중점적으로 리뷰 할 부분