Merge pull request #24 from gdud/bugfix/replicas-hpa-enabled

Do not set replicas when HPA is enabled
dnvgl · Apr 18, 2023 · 57efbf4 · 57efbf4
2 parents 642b183 + f6ccf36
commit 57efbf4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/charts/platform-service/Chart.yaml b/charts/platform-service/Chart.yaml
@@ -2,4 +2,4 @@ apiVersion: v1
 appVersion: "1.1"
 description: Platform service chart
 name: platform-service
-version: 1.2.1
+version: 1.2.2
diff --git a/charts/platform-service/templates/deployment.yaml b/charts/platform-service/templates/deployment.yaml
@@ -25,7 +25,9 @@ spec:
   strategy:
     type: Recreate
   {{- end }}
+  {{- if not .Values.hpa.enabled }}
   replicas: {{ .Values.replicaCount }}
+  {{- end }}
   selector:
     matchLabels:
       app.kubernetes.io/name: {{ include "platform-service.name" . }}

diff --git a/charts/platform-service/values.yaml b/charts/platform-service/values.yaml
@@ -4,7 +4,7 @@
 app: app        # Required
 
 version: v1
-replicaCount: 1
+replicaCount: 1 # This value is skipped in deployment when hpa.enabled is set to true
 
 mergeAppMetrics: false