Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/way more styles #2

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Feature/way more styles #2

wants to merge 18 commits into from

Conversation

ajb
Copy link
Contributor

@ajb ajb commented Mar 19, 2015

@jrubenoff: This is my attempt at styling a cross-browser file picker. It doesn't really work too well, though... in old IE, you can only click on the "Browse" button. In old FF, you can only click on "Choose a file...". It's odd.

img

There are also some styling problems that I ran into, when trying to make the span look like a button. It needs to be a span because other browsers have problems if it's an a.

If you want to try and get this working in all browsers, this is our best shot at having an input component that's more styleable.

I would note, too, that the wtfforms.com version doesn't work in old FF either.

To develop this:

  1. script/bootstrap
  2. script/server,
  3. open http://localhost:9393/users/new, click "Submit"
  4. Use http://localhost:9393/users/1/edit as your debugging page.

If you make changes to component.rb, you'll need to restart the server.

span.pfi_existing_filename @filename
text ' '
a.button.mini.info 'Remove', 'data-pfi-remove' => true
div.js_pfi_toggle.pfi_file_wrapper(style: @filename ? nil : 'display:none;') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [84/80]
Avoid using {...} for multi-line blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants