This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
ECS: supporting x-aws-assign_public_ip #2214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BackSlasher
force-pushed
the
public-ip
branch
2 times, most recently
from
6be1902 to
f6725e2
Compare
|
comment for me: 6be1902 |
BackSlasher
force-pushed
the
public-ip
branch
from
f6725e2 to
531bf3d
Compare
|
From testing, it seems that tasks without a public IP are unable to reach docker to pull images: I might change the default to be "true" then, or move to changing the security group structure insteaad |
Summary: Can be used to test service-service interaction, and stacks with more than one service Test Plan: This is a test
Allowing users to choose whether their instances should get a public IP address or not. Defaulting to "no". Signed-off-by: Nitzan Raz <[email protected]>
BackSlasher
force-pushed
the
public-ip
branch
from
531bf3d to
c308a67
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing users to choose whether their instances should get a public IP address or not. Defaulting to "no".
What I did
Supporting
x-aws-assign_public_ipin the service level.If not present / set to a falsy value, the service should not get a public IP address.
If set to a truthy value, the current behavior exists (set by the provider's capability).
I'm not touching the EC2 section as it seems a bit messed up anyway, and I suspect it's not covered by tests.
Related issue
#2213
Created new "slightly complex" test to cover my change. I intend to reuse it later as well.
(not mandatory) A picture of a cute animal, if possible in relation with what you did
Called Dubi. A friendly street cat.