Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git authentication to support the private repo case #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Mazgis47
Copy link

Example usage:
bashbrew --library mylibrary --git-username MyGithubUser --git-password ghp_123456789 --debug --cache /tmp/bashbrew_cache --namespace docker-images.mycompany.com/myalpine build --all --pull always

@tianon
Copy link
Member

tianon commented Mar 23, 2022

Thanks for the contribution!

I think rather than adding explicit (manual) support for HTTP authentication to all our Git calls, I'd rather find out / figure out whether go-git supports https://git-scm.com/docs/gitcredentials properly so we can avoid having to specify this everywhere (especially since it's a feature we won't be using, so it won't be getting very much testing and we'll be likely to remove it if it ever has issues or requires changes).

@Mazgis47
Copy link
Author

Thanks for the contribution!

I think rather than adding explicit (manual) support for HTTP authentication to all our Git calls, I'd rather find out / figure out whether go-git supports https://git-scm.com/docs/gitcredentials properly so we can avoid having to specify this everywhere (especially since it's a feature we won't be using, so it won't be getting very much testing and we'll be likely to remove it if it ever has issues or requires changes).

If I correctly understand they have an open issue on that src-d/go-git#1101 so it is a blocker/dependency to use go-git. There is an example provided but that is not a part of the go-git.

@yosifkit
Copy link
Member

It looks like someone is currently working on adding git credentials support: go-git/go-git#490. So, we should wait until that is available.

(also, we shouldn't be pulling in any dependencies from src-d/go-git since it is an abandoned and archived repo and development has moved to go-git/go-git)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants