Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Apache mod_expires #247

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Conversation

jonathanthiry
Copy link
Contributor

It will allow Drupal to set cache headers https://github.com/drupal/drupal/blob/10.0.x/.htaccess#L34.

The expires module is enabled the same in the Wordpress Dockerfile https://github.com/docker-library/wordpress/blob/master/Dockerfile.template#L161

@tianon
Copy link
Member

tianon commented Dec 1, 2023

Heh, did some digging on WordPress and it looks like we added that a very long time ago (docker-library/wordpress#107 -> docker-library/wordpress#111), and before we were taking a harder line on following upstream's explicit recommendations, and I can't actually find anything from WordPress upstream recommending the use of mod_expires so we probably wouldn't enable it there today, if it were requested and we didn't already have it (and it's now tempting me to remove it in the future).

Do you know whether Drupal has anything explicitly recommending enabling mod_expires for deployments?

@tianon
Copy link
Member

tianon commented Dec 1, 2023

Oh, apologies, I got so distracted with WordPress I missed your link to https://github.com/drupal/drupal/blob/10.0.x/.htaccess#L34! I agree, that seems like a pretty decent endorsement. 👍

It will allow Drupal to set cache headers https://github.com/drupal/drupal/blob/10.0.x/.htaccess#L34.

The expires module is enabled the same in the Wordpress Dockerfile https://github.com/docker-library/wordpress/blob/master/Dockerfile.template#L161
@tianon tianon merged commit ee9db81 into docker-library:master Dec 2, 2023
50 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 2, 2023
Changes:

- docker-library/drupal@ee9db81: Merge pull request docker-library/drupal#247 from jonathanthiry/patch-1
- docker-library/drupal@02cf2c3: Enable Apache mod_expires
- docker-library/drupal@b2ba48a: Merge pull request docker-library/drupal#250 from infosiftr/php8.0-eol
- docker-library/drupal@7d8447c: Remove php8.0 variants as it has reached end of life
@jonathanthiry
Copy link
Contributor Author

Thanks for taking the time to review and integrate this @tianon !

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 5, 2023
Changes:

- docker-library/drupal@927f080: Merge pull request docker-library/drupal#252 from infosiftr/eol-and-new
- docker-library/drupal@9df694c: Add 10.2-rc
- docker-library/drupal@decc26f: Drop eol 9 series
- docker-library/drupal@ee9db81: Merge pull request docker-library/drupal#247 from jonathanthiry/patch-1
- docker-library/drupal@02cf2c3: Enable Apache mod_expires
- docker-library/drupal@b2ba48a: Merge pull request docker-library/drupal#250 from infosiftr/php8.0-eol
- docker-library/drupal@7d8447c: Remove php8.0 variants as it has reached end of life
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants