Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "tip" version #531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add "tip" version #531

wants to merge 1 commit into from

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 15, 2024

This is pinned to the latest commit merged upstream before midnight (UTC) on Monday of the current week (#464 (comment), https://github.com/docker-library/faq#can-i-use-a-bot-to-make-my-image-update-prs).

Closes #464

(Includes/based on #530)

{{ ) else ( -}}
# before we get too far, let's validate that our "bootstrap" Go works
export GOROOT_BOOTSTRAP=/usr/local/goroot-bootstrap; \
# TODO figure out why QEMU's user-mode emulation with Go 1.23.0 causes "can't start telemetry child process: fork/exec /usr/local/go/bin/go: invalid argument" (it works if we run it a second time, but then later "go build" fails to fork/exec the compile process 🙃)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of this "fun" with Go 1.23 + QEMU, I haven't done much testing of this on architectures other than amd64 and i386, so that's a notable blind spot that's probably worth more testing before we consider merging

@@ -111,8 +111,6 @@ for version; do

fullVersion="$(jq -r '.[env.version].version' versions.json)"

[[ "$fullVersion" == *.*[^0-9]* ]] || fullVersion+='.0'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is technically valid even without this PR, but it's currently harmless (however with it in this PR, we end up with tags like tip-YYYYMMDD.0, which is undesirable).

@@ -159,7 +242,7 @@ for version in "${versions[@]}"; do
"3.19",
empty
| "alpine" + .),
if .arches | has("windows-amd64") and .["windows-amd64"].url then
if .arches | has("windows-amd64") and .["windows-amd64"].url then # TODO consider windows + tip
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's technically very doable for us to implement Windows support, but this was enough that I didn't want to get too much deeper and decided to leave Windows as a TODO for now instead.

@tianon
Copy link
Member Author

tianon commented Aug 15, 2024

$ diff -u <(bashbrew cat golang) <(bashbrew cat <(./generate-stackbrew-library.sh))
--- /dev/fd/63	2024-08-15 16:35:29.584348497 -0700
+++ /dev/fd/62	2024-08-15 16:35:29.584348497 -0700
@@ -2,6 +2,27 @@
 GitRepo: https://github.com/docker-library/golang.git
 Builder: buildkit
 
+Tags: tip-20240810-bookworm, tip-bookworm
+SharedTags: tip-20240810, tip
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/bookworm
+
+Tags: tip-20240810-bullseye, tip-bullseye
+Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/bullseye
+
+Tags: tip-20240810-alpine3.20, tip-alpine3.20, tip-20240810-alpine, tip-alpine
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, riscv64, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/alpine3.20
+
+Tags: tip-20240810-alpine3.19, tip-alpine3.19
+Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x
+GitCommit: 819b7657d7783ea8b838ad2497af40f785119ccb
+Directory: tip/alpine3.19
+
 Tags: 1.23.0-bookworm, 1.23-bookworm, 1-bookworm, bookworm
 SharedTags: 1.23.0, 1.23, 1, latest
 Architectures: amd64, arm32v7, arm64v8, i386, mips64le, ppc64le, s390x

This is pinned to the latest commit merged upstream before midnight (UTC) on Monday of the current week.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:tip tag
1 participant