Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove several (persistently) failing builds #17382

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

tianon
Copy link
Member

@tianon tianon commented Aug 16, 2024

This comment has been minimized.

@tianon
Copy link
Member Author

tianon commented Aug 16, 2024

cc node folks explicitly: @LaurentGoderre @PeterDaveHello @SimenB @Starefossen @nschonni @ttshivers

(this will likely require adjustments in the bot which is generating your library/node PRs -- also, it would be really helpful to include at least one of y'all with at minimum a GitHub handle in Maintainers: so we don't have to go dig up this list on any PR that isn't made by your bot)

@nschonni
Copy link
Contributor

I agree that some of the architectures are broken now, and probably have no simple path to a fix, but I think this needs to go into https://github.com/nodejs/docker-node/blob/main/versions.json for the specific broken node versions. EX: some of the broken things are for v22, or old versions, not all release lines

@tianon
Copy link
Member Author

tianon commented Aug 19, 2024

Indeed, that's what I was trying to get at with this:

this will likely require adjustments in the bot which is generating your library/node PRs

I am not sure exactly where in the Node.js repository those change need to be made to exclude ppc64le from Node.js 22, but yes, to prevent your bot from bringing them right back, this change needs to be made there too.

@nschonni
Copy link
Contributor

Is it just the Alpine ppc64le that's consistently failing, or all the image variants of ppc64le on 22?

@tianon
Copy link
Member Author

tianon commented Aug 19, 2024 via email

@gabor-boros
Copy link
Contributor

Hey @tianon,
The download server is back online for RethinkDB. Could you please remove that from this Pull Request? Ref: rethinkdb/rethinkdb#7153 (comment)

@tianon
Copy link
Member Author

tianon commented Aug 19, 2024

Thank you, confirmed and done!

This comment has been minimized.

Each of these has been failing for some period of time with no fix/mitigation forthcoming.  We're happy to see them re-enabled if they are fixed/updated.
@tianon
Copy link
Member Author

tianon commented Aug 19, 2024

Rebased to drop node (#17394)

Copy link

Diff for d7725a1:
diff --git a/_bashbrew-arches b/_bashbrew-arches
index 79acf81..0484d35 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -4,4 +4,3 @@ arm32v7
 arm64v8
 i386
 ppc64le
-s390x
diff --git a/_bashbrew-cat b/_bashbrew-cat
index 7ea1929..0d99ae6 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1,6 +1,6 @@
 # eclipse-mosquitto
 Maintainers: Roger Light <[email protected]> (@ralight)
-Architectures: amd64, arm32v6, arm64v8, i386, ppc64le, s390x
+Architectures: amd64, arm32v6, arm64v8, i386, ppc64le
 GitRepo: https://github.com/eclipse/mosquitto.git
 GitCommit: f4400fa422eacac8417efbc45dd1284526dce8d4
 
@@ -19,7 +19,6 @@ Maintainers: Alin Voinea <[email protected]> (@avoinea), Piero Nicolli <pier
 GitRepo: https://github.com/plone/plone.docker.git
 
 Tags: 5.2.14-python38, 5.2-python38, 5-python38, python38, 5.2.14, 5.2, 5, latest
-Architectures: amd64, arm64v8
 GitCommit: a3a9c7e0c5ca324f488fe7354f00a997398195f7
 Directory: 5.2/5.2.14/debian
 
@@ -36,6 +35,6 @@ Directory: 8.4/alpine3.19
 
 Tags: 8.4.0-bookworm, 8.4-bookworm, 8-bookworm, bookworm
 SharedTags: 8.4.0, 8.4, 8, latest
-Architectures: amd64, arm64v8, ppc64le, s390x
+Architectures: amd64, arm64v8
 GitCommit: 69038a84d541717d66420f3ad8ec7c9da22c91b4
 Directory: 8.4/bookworm

Relevant Maintainers:

@yosifkit yosifkit merged commit 60d3d1b into docker-library:master Aug 19, 2024
11 checks passed
@yosifkit yosifkit deleted the failing-builds branch August 19, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants