Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not delete source files when debugging #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yyny
Copy link

@yyny yyny commented Feb 19, 2024

No description provided.

@tianon
Copy link
Member

tianon commented Feb 20, 2024

This "oh, but one more thing" is actually part of the reason why we resisted implementing DOCKER_PHP_ENABLE_DEBUG for so long 😅 ❤️

In this specific case, this is really trivial to implement via docker-php-source extract post-build, so without a stronger justification than "it'd be handy", I'm afraid this one is a likely decline. 🙇

@mvorisek
Copy link
Contributor

I support this PR. When debug build is enabled, it does not make any sense to remove the sources. I understand the post from @tianon, but let's make developers live not harder.

@yyny
Copy link
Author

yyny commented Feb 23, 2024

docker-php-source extract wouldn't quite work for me because I am patching the sources.

@WarDroid23

This comment was marked as spam.

@WarDroid23

This comment was marked as spam.

WarDroid23

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants