Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bison for Ruby 3.3.0 #438

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

hachi8833
Copy link
Contributor

ref: ruby/ruby#7798

Since Ruby 3.3 bison has been unnecessary to build Ruby.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a couple suggestions to make sure this only applies to 3.3+ (which I'm happy to apply myself if you'd prefer ❤️)

Dockerfile.template Show resolved Hide resolved
Dockerfile.template Show resolved Hide resolved
@hachi8833
Copy link
Contributor Author

hachi8833 commented Feb 7, 2024

which I'm happy to apply myself if you'd prefer

@tianon Yes, you can apply the change by yourself and close this PR instead ❤️

@tianon
Copy link
Member

tianon commented Feb 7, 2024

It's OK, I'll just update your PR in-place 😄

@yosifkit yosifkit merged commit 7e8e485 into docker-library:master Feb 7, 2024
25 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 7, 2024
Changes:

- docker-library/ruby@7e8e485: Merge pull request docker-library/ruby#438 from hachi8833/remove_bison_for_ruby330
- docker-library/ruby@90c7a1d: Remove unnecessary bison for Ruby 3.3.0
@hachi8833 hachi8833 deleted the remove_bison_for_ruby330 branch March 15, 2024 10:53
martin-g pushed a commit to martin-g/docker-official-images that referenced this pull request Apr 3, 2024
Changes:

- docker-library/ruby@7e8e485: Merge pull request docker-library/ruby#438 from hachi8833/remove_bison_for_ruby330
- docker-library/ruby@90c7a1d: Remove unnecessary bison for Ruby 3.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants