Add more defensive mkdir for GEM_HOME
#463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whalelines
reviewed
Jun 25, 2024
| # adjust permissions of a few directories for running "gem install" as an arbitrary user | ||
| RUN mkdir -p "$GEM_HOME" && chmod 1777 "$GEM_HOME" | ||
| RUN set -eux; \ | ||
| mkdir "$GEM_HOME"; \ |
There was a problem hiding this comment.
Do we expect all parent directories of $GEM_HOME to exist? Removing the -p causes mkdir to fail if the directory already exists, which is desireable, but it also means parent directories are not automatically created, which would be bad if all of $GEM_HOME's parent directory do not exist in the image layers prior to this RUN command.
There was a problem hiding this comment.
It looks like all the Dockerfiles have a mkdir -p /usr/local/etc in a previous RUN statement, so this should be good.
There was a problem hiding this comment.
Indeed, and Ruby itself ends up in /usr/local via make install
whalelines
approved these changes
Jun 25, 2024
yosifkit
approved these changes
Jun 25, 2024
LaurentGoderre
approved these changes
Jun 26, 2024
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 28, 2024
Changes: - docker-library/ruby@c069afc: Merge pull request docker-library/ruby#463 from infosiftr/mkdir-gem-home - docker-library/ruby@f69cac9: Add more defensive `mkdir` for `GEM_HOME`
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jul 9, 2024
Changes: - docker-library/ruby@2e432fc: Update 3.3 to 3.3.4 - docker-library/ruby@c069afc: Merge pull request docker-library/ruby#463 from infosiftr/mkdir-gem-home - docker-library/ruby@f69cac9: Add more defensive `mkdir` for `GEM_HOME`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops the
-pargument inmkdir -p "$GEM_HOME"to ensure that this validates our assumption that ourGEM_HOMEdid not exist before this line and is indeed created (as a new, empty directory) by this line.cc @whalelines (whose idea validating better this was)