-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test case to document env header contains whitespace error as expected behavior. #5081
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR :)
This already looks quite good. Just a few comments from my side.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5081 +/- ##
=======================================
Coverage 61.33% 61.33%
=======================================
Files 298 298
Lines 20692 20691 -1
=======================================
Hits 12691 12691
+ Misses 7100 7099 -1
Partials 901 901 |
Thanks @Benehiko, I merged back up with master, it seems my editor was trying to change formatting on container_run.md, but I think I got it fixed. Let me know any feedback! Thank you! |
My bad, when I followed the DCO after the merge by running |
Woops, don't stress! Everyone has had something like this happen to them :) I think it might be best to reset your master branch on your fork with the upstream (docker/cli) and then cherry pick a283791 and 6b9a70b and push the cherry pick. You should be able to do this by adding the docker/cli repo as an upstream remote repository then fetch all commits from the upstream. Reset your fork's master to the upstream master and force push. Then cherry pick your original commit a283791 and 6b9a70b on your fork's master and push. https://stackoverflow.com/questions/9646167/clean-up-a-fork-and-restart-it-from-the-upstream As the SO post mentions, you should also probably backup your work on a separate branch before doing the reset. create a new branch that's clean and cherry pick your work a283791 and 6b9a70b. Commit that to this branch - then once you have it you can do the reset. |
- What I did
[config 1]
will throw an error is expected behavior.docker run
throws error if an env var contains whitespace #5057- How to verify it
docker buildx bake test
looked good to me- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)