list/tree: Hide Used column if no truthy value #5357
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
area/ux
containerd-integration
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5357 +/- ##
==========================================
- Coverage 60.92% 60.90% -0.02%
==========================================
Files 304 304
Lines 21340 21345 +5
==========================================
Hits 13001 13001
- Misses 7409 7414 +5
Partials 930 930 |
|
I'm not totally sure about this from a UX perspective.. wouldn't it risk being a bit confusing for the users if sometimes they see the column and sometimes they don't? |
|
I'm fine with it for now since this is behind an experimental flag, but we should review these questions before making it stable. |
Don't show the `Used` column in the image tree view when no image is actually used and the column would be empty. Signed-off-by: Paweł Gronowski <[email protected]>
vvoland
force-pushed
the
list-tree-hide-used
branch
from
324ba25
to
54a4ab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't show the
Usedcolumn in the image tree view when no image is actually used and the column would be empty.- A picture of a cute animal (not mandatory but encouraged)