Remove /json from API URLs

[bfirsh]

See moby/moby#23219

[calavera]

LGTM

[bfirsh]

FWIW this has a hard dependency on moby/moby#23219, and that has stalled on a design decision.

[vdemeester]

Moving to code-review as moby/moby#23219 is in code-review

[vdemeester]

LGTM 🐹

[calavera]

still LGTM

[tamird]

So...this makes this library not work with older docker versions? For example, the latest version offered by CircleCI is 1.10.

[thaJeztah]

Oh, yes, I wonder if this should be reverted, given that there's no full agreement yet in moby/moby#23219 (comment)

[vdemeester]

@tamird arf, yeah that is pretty bad 😓
I'll revert this for now and we'll find a better way to handle it

[tamird]

Tim BL had it right all the way back in 1998 https://www.w3.org/Provider/Style/URI.html

[vdemeester]

@tamird the old URL won't change (probably for the next… 5 years or eternity) but the client code might… although we didn't do right… Sorry about that 😓

[tamird]

This client code should also not change until all docker versions that don't support these URLs are EOL'd.

Making this change now is breaking compatibility for no benefit whatsoever, especially given the state of dependency management in Go.

[vdemeester]

@tamird see #263 🙇

[tamird]

👍 thanks

[bfirsh]

My bad. I should have closed this while there was still a design decision in moby/moby#23219.

I wonder if we should open the discussion about how to version engine-api. People should presumably be locking to API versions somehow rather than using master. (See also #260.)

[bfirsh]

Ah, nevermind, I see there is cli.version, so I should have used that in this PR to check what URL to make the request to.

Perhaps we should set the default version to the current stable version of Docker so people using engine-api off master don't get broken by default.

[vdemeester]

Perhaps we should set the default version to the current stable version of Docker so people using engine-api off master don't get broken by default.

That's a good idea 👼

[bfirsh]

@vdemeester I suppose you have to explicitly pass a blank string to client.NewClient if you don't set a version, I guess that's pretty much saying "I expect this to break". I'll add a warning to the godoc that you really should be specifying a version.

It's different for NewEnvClient though: #264