Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Ensure that more than 100 issues/pull requests are considered in release notes GraphQL queries #12

Closed
Ocramius opened this issue Apr 8, 2019 · 1 comment
Closed

Ensure that more than 100 issues/pull requests are considered in release notes GraphQL queries #12

Ocramius opened this issue Apr 8, 2019 · 1 comment
Assignees
@Ocramius
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Ocramius
Copy link
Member

Ocramius commented Apr 8, 2019

The code at

automatic-releases/src/Github/Api/GraphQL/Query/GetMilestoneChangelog.php

Lines 79 to 86 in e183b78

return Milestone::fromPayload($this->runQuery->__invoke(
self::QUERY,
[
'repositoryName' => $repositoryName->name(),
'owner' => $repositoryName->owner(),
'milestoneNumber' => $milestoneNumber,
]
)['repository']['milestone']);
does not handle pagination at all, which means that >100 entries will lead to problems.
@Ocramius Ocramius added the bug Something isn't working label Apr 8, 2019
@Ocramius Ocramius self-assigned this Aug 2, 2020
@Ocramius Ocramius added the duplicate This issue or pull request already exists label Aug 2, 2020
@Ocramius
Copy link
Member Author

Ocramius commented Aug 2, 2020

Duplicate of laminas/automatic-releases#6

@Ocramius Ocramius marked this as a duplicate of laminas/automatic-releases#6 Aug 2, 2020
@Ocramius Ocramius closed this as completed Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Ocramius Ocramius

Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ocramius