Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Known limitation: can only handle the first 100 issues/PRs in a release #6

Open
asgrim opened this issue Jul 10, 2020 · 3 comments
Open

Known limitation: can only handle the first 100 issues/PRs in a release #6

asgrim opened this issue Jul 10, 2020 · 3 comments
Labels
Bug Something isn't working

Comments

@asgrim
Copy link
Member

asgrim commented Jul 10, 2020

Bug Report

Q A
Version(s) 1.0.0

Summary

This is a known limitation currently.
@Ocramius Ocramius added the Bug Something isn't working label Jul 10, 2020
@Ocramius
Copy link
Member

Affected code:

automatic-releases/src/Github/Api/GraphQL/Query/GetMilestoneFirst100IssuesAndPullRequests.php

Line 12 in ea00621

final class GetMilestoneFirst100IssuesAndPullRequests implements GetGithubMilestone

An alternative implementation that can use graphql pagination is needed here.

@Slamdunk
Copy link

Or, you know, you can write better software, so each release has fewer bugs or errors and hence few issues/PR

@Ocramius
Copy link
Member

Hahahahahaha :D

Well, as it stands, that implementation is non-total, which is a clear bug. Whether it affects you is secondary 👍

@Ocramius Ocramius mentioned this issue Aug 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Slamdunk @Ocramius @asgrim