Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build (local and GH) and Lambda runtime to use NodeJS v18 #1628

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jasonburkert-ccpo
Copy link
Contributor

@jasonburkert-ccpo jasonburkert-ccpo commented May 5, 2023

This began as a way to prove NodeJS 18 is supported in GovCloud and would work for us in region us-gov-west-1 (and hence an upgrade was no longer blocked). But with positive results, this PR may as well be used to accomplish the two tickets below.

  • Switches lambda runtimes to use lambda.Runtime.NODEJS_18_X instead of lambda.Runtime.NODEJS_16_X
  • Switches local builds and GitHub Actions builds to use NodeJS v18 instead of v16

Tickets: AT-8949, AT-8617

@jasonburkert-ccpo
Copy link
Contributor Author

Deployed OK

image

Executed OK

image

Ticket: AT-8617
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jasonburkert-ccpo
Copy link
Contributor Author

Built OK locally

image

Built OK on GitHub Actions

https://github.com/dod-ccpo/atat-web-api/actions/runs/4895350315
image

@jasonburkert-ccpo jasonburkert-ccpo changed the title update Lambda runtime to NODEJS_18_X Update build (local and GH) and Lambda runtime to use NodeJS v18 May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant