Fixes: eclipse-bluechi#591

When an anonymous node has been disconnected in the controller
and the cleanup has been done, a log statement was made afterwards.
This statement differed based on the node name. Since the node
instance has been cleaned up (freed), but not set to NULL, valgrind
reported this as an invalid read. Moved the log statements
accordingly.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

The getting started page now provides a guide to setup
BlueChi for single and multiple nodes. Also, examples
on how to use BlueChi have been added - from getting
information using bluechictl to a full example of how
to use BlueChi's proxy service feature.

Signed-off-by: Michael Engel <[email protected]>

Renames bluechi RPM to bluechi-controller, which better describes the
content of the package.

Signed-off-by: Martin Perina <[email protected]>

Moves bluechi snapshot builds from mperina/hirte-snapshot repo to
@centos-sig-automotive/bluechi-snapshot repo.

Signed-off-by: Martin Perina <[email protected]>

In the error cases in this function a file descriptor is getting leaked,
use steal_fd and cleanup_fd to alleviate this. Found by gcc's
-fanalyzer.

Signed-off-by: Eric Curtin <[email protected]>

Add skipper environment configuration
Skip git config operation when running the containerized build
Add strato-skipper to the requirements.txt file
Update the tests README

Signed-off-by: Ygal Blum <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

The current architecture overview of BlueChi uses
bluechi instead of bluechi-controller. Since the
diagram wasn't in the drawio xml, it has been
recreated.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Fixes: eclipse-bluechi#566

Adds the missing api examples for rust on how to
use BlueChi's D-Bus API.

Signed-off-by: Michael Engel <[email protected]>

[WIP]
When running tmt gcda and gcno files are created. This files necessary for later code coverage.
So before the container destroyed we need to extract this files to the local machine.

Related: eclipse-bluechi#397
Signed-off-by: Artiom Divak <[email protected]>

Added arguments for meson so the gcda files will be saved in /var/tmp/bluechi-coverage.
Also bluechi.spec.in will add the /var/tmp/bluechi-coverage.

Signed-off-by: Artiom Divak <[email protected]>

Add path for gcda files

Added arguments for meson so the gcda files will be saved in /var/tmp/bluechi-coverage.
Also bluechi.spec.in will add the /var/tmp/bluechi-coverage.

Signed-off-by: Artiom Divak <[email protected]>

Each test case should have unique UUID to help with traceability of test runs.
With UUID for each test case, it is easier to follow trends in stability over time.

Signed-off-by: Pavol Brilla <[email protected]>

thanks this makes sense

Co-authored-by: Michael Engel <[email protected]>
Signed-off-by: Pavol Brilla <[email protected]>

We were setting up specific network range for integration tests, but we
were not using it directly within any test. So we can remove that
specific network setup and rely on the default.

Signed-off-by: Martin Perina <[email protected]>

Running integration tests with `-v` option provides nice summary with
each test execution time and result at the end of the run, so we should
suggest using this option everywhere in the documentation.

Signed-off-by: Martin Perina <[email protected]>

Use only `shell` to indicate that code block should use shell syntax
highlighting.

Signed-off-by: Martin Perina <[email protected]>

1. Mention all environment variables, which are used within integration
   tests and could be changed by users, in `tests/plans/tier0.fmf`
2. Mention using `-e` to change environment variable value for an
   integration tests run in the documentation

Signed-off-by: Martin Perina <[email protected]>

Signed-off-by: Iiqbal2000 <[email protected]>

When we build RPMs with coverage support (which we do only when we want
to generate code coverage report), it's easier to add bluechi-coverage
RPM as a dependency to other RPMs than passing coverage support to the
container file and installing bluechi-coverage RPM according to the
coverage support enablement.

Signed-off-by: Martin Perina <[email protected]>

BlueChi Tester, its purpose is to create tests that can disrupt or
diminish the functionality of the BlueChi controller.

Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Signed-off-by: Michael Engel <[email protected]>

Related to: eclipse-bluechi#604

Added the gcc option -fanalyzer as configurable meson option
(default: false) to ensure higher code quality. Default is
set to false and no integration into CI is done since it can
also result in false-positives. Therefore, the developer has
to decide which issue to tackle.

Signed-off-by: Michael Engel <[email protected]>

Fixes: eclipse-bluechi#415

Added an integration test to validate that collecting metrics
for the start time of a unit works as expected.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

In order to ensure every integration test has an ID linked to
it, a CI step executes a dry run for the generation and checks
the result.

Signed-off-by: Michael Engel <[email protected]>

Fixes: eclipse-bluechi#604

Fixed detected issues or suppressed warnings for false-positives
that couldn't be fixed. In addition, the -fanalyzer option has
been enabled in the CI for the build and running unit tests.
The clang-tidy unknown warning option has been disabled, too.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

clang/LLVM is an alternate C compiler that is commonly used in Linux and
other operating systems. It has useful tooling and helps keep the code
portable. Other projects that use this toolchain include Chromium, Linux
kernel and virtually all Rust projects use LLVM backend.

Signed-off-by: Eric Curtin <[email protected]>

The value of ManagerAddress was being overridden upon connection failure

Signed-off-by: Ygal Blum <[email protected]>

Some changes were made to account for unused variables the LLVM
toolchain found, it also did not recognize the gcc-specific warnings
turned off by the pragma statements, so tell clang to just ignore
those.

Signed-off-by: Eric Curtin <[email protected]>

Changed the section name to cross-node dependencies
and added an introducing index page to it. Reworked
the proxy service example and explanation as well as
added the limitations of this feature. In addition,
a how-to subsection was created.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

By using ExecStop= instead of ExecStart= a race condition is
avoided that leads systemd to send a SIGTERM signal to the
dep service, resulting in it being in a failed state.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Fixes: eclipse-bluechi#413
Adds an integration test to verify that unsubscribe is
automatically called as soon as the consumer stops the
connection (the event loop, in this case).

Signed-off-by: Michael Engel <[email protected]>

The const qualifier for the sub_id prevented the value from
being changed, so an unsubscribe call would fail since the
subscription with ID 0 could not be found.

Signed-off-by: Michael Engel <[email protected]>

Passing `--arch` parameter to `podman build` in
`tests/scripts/tests-setup.sh` is no longer needed after
eclipse-bluechi#441 being merged.

Signed-off-by: Martin Perina <[email protected]>

- Adapt our RPM build scripts to be usable in packit
- Add support to build RPMs for the most important architectures when PR
  is added/updated
- Add support to build RPMs for all supported platforms and save produced
  RPMs into our COPR repository

Fixes: eclipse-bluechi#452
Signed-off-by: Martin Perina <[email protected]>

- Adapt our integration tests to be executable by packit in the testing
  farm
- Add support to execute integration tests after RPMs are built when PR
  is added/updated

Fixes: eclipse-bluechi#452
Signed-off-by: Martin Perina <[email protected]>

Aligns build targets for bluechi-snapshot packit builds with the build
targets we were using with `make srpm` builds prior packit integration.

Signed-off-by: Martin Perina <[email protected]>

There is a potential race condition for ExecStart in
[email protected] when a stop signal is sent and
the ExecStart= command is still running. This leads
systemd to send a SIGTERM signal to the template service.
Therefore, SIGTERM needs to be an acceptable exit status,
otherwise the service transitions to a failed state.

Signed-off-by: Michael Engel <[email protected]>

setting pointers to NULL after free

Signed-off-by: Michael Engel <[email protected]>

Fixes: eclipse-bluechi#454

Moves the project version and release to a dedicated script
and uses it in meson. It also extends the -v cli option of
all binaries so that the release (incl. the commit hash for
nightly builds) is included.

Signed-off-by: Michael Engel <[email protected]>

Added graceful node_shutdown function that is called before node_unref
which goes over outstanding requests and cancels them.

This fixes a memory leak when bluechi-controller service is stopped
via bluechi-controller itself

Signed-off-by: Mark Kemel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

…ib by casting raw pointers to each original object

Signed-off-by: Iiqbal2000 <[email protected]>

Signed-off-by: Mark Kemel <[email protected]>

New label to the regular packit test job, in addition to the existing
`valgrind` one. The labels allow triggering a single job or a group
of jobs manually. In our case:
`/packit test --labels standard` - runs the regular test job
`/packit test --labels valgrind` - runs the valgrind test job
`/packit test` - runs both (all the) tests

Signed-off-by: Mark Kemel <[email protected]>

Relates to: eclipse-bluechi#187

When a peer creates a monitor, events matching its subscriptions
should be sent only to that peer. Currently, this is only
implemented for the unit properties changed signal - the other
events are broadcasted so that others receive those signals as well.
This commit changes the events for UnitNew, UnitRemoved and
UnitStateChanged to be only sent to the peer that created the monitor.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Fix remaining URLs pointing to container/bluechi to point to
eclipse-bluechi/bluechi

Signed-off-by: Martin Perina <[email protected]>

Split build and push into two distinct functions. Also, renamed
functions and added an parameter check.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Relates to:
eclipse-bluechi#567
eclipse-bluechi#568

When list units for all nodes is run and the requests are submitted,
it might happen that one of those is failing. Previously, this led
to a failure when reading the message for the node where the request
failed - which got propagated to the caller.
Now, an additional error log in BlueChi is made and the error code
is extracted from the sd_bus_message.
Also removes the top-most error print in the client to avoid printing
errors twice.

Signed-off-by: Michael Engel <[email protected]>

Relates to:
eclipse-bluechi#648

In order to continuously send signals to bluechi-controller
a value of 0 in --numbersignals can be used for running in
an infinite loop. In addition, the paramters for the JobDone
signal have been fixed so that a valid JobDone signal is
sent.

Signed-off-by: Michael Engel <[email protected]>

Fixes containers/podman-py#350 by forcing
installation of python-rich dependency, which is missing in
podman-py 4.8.0.post1

Signed-off-by: Martin Perina <[email protected]>

Relates to: eclipse-bluechi#187

Monitor signals are only sent to the creator of the monitor. The
new Peer API enables to add and remove additional listener on the
same monitor with its subscriptions.
A user with sufficient priviledges to make methods calls to BlueChi's
API can add and remove peers. The processes for the peers can be run
by a different user with no access to BlueChi's API, but will still
be able to receive events if added by a privileged process.

Signed-off-by: Michael Engel <[email protected]>

Adds lcov to integration-test-base container, because lcov will be
required to generate code coverage report from integration tests run.

Related-to: eclipse-bluechi#397
Signed-off-by: Martin Perina <[email protected]>

Relates to: eclipse-bluechi#397

In order to finalize all data - journal and valgrind logs and
code coverage files - a shutdown step has been introduced that
stops the bluechi components in all container.
Also, error logs have been added in the run routine that should
help debugging test failures.

Signed-off-by: Michael Engel <[email protected]>

Adds a failure message to PR as a new comment, if packit build fails
after merge of the PR.

Signed-off-by: Martin Perina <[email protected]>

Relates to: eclipse-bluechi#187

Added integration tests to validate that the implemented
API for adding and removing peers on monitors works as
expected.

Signed-off-by: Michael Engel <[email protected]>

In order to prevent duplicated signals being sent to
a peer, the add peer method checks for the bus id and
rejects if it can be found. This also applies to the
owner of the monitor.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

In some of the proxy monitors send function an error
variable had been declared, but not used (due to an
async method call). These can safely be removed.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Ygal Blum <[email protected]>

Signed-off-by: Michael Engel <[email protected]>

Relates to: eclipse-bluechi#187

Added documentation about monitors, virtual events and the
recently introduced peer listener API.

Signed-off-by: Michael Engel <[email protected]>

Get Info file file from each container of each test.
This info files will be merged with lcov command.

Fixes: eclipse-bluechi#397
Signed-off-by: Artiom Divak <[email protected]>

Running script when WITH_COVERAGE is 1. This script will run after all
tests and will get an html report for the coverage from all the info
files.

Fixes: eclipse-bluechi#397
Signed-off-by: Artiom Divak <[email protected]>

Related-to: eclipse-bluechi#397
Signed-off-by: Martin Perina <[email protected]>

- Adds plain (just a chihuahua), horizontal and vertical variants of the
  logo
- Adds vertical variant to README.md

Signed-off-by: Martin Perina <[email protected]>

Signed-off-by: Martin Perina <[email protected]>

Adds BlueChi vertical logo in 100x100 size to be used as a logo for
Eclipse BlueChi organization and repo on GitHub.

Signed-off-by: Martin Perina <[email protected]>

Adds horizontal logo sized to 1280x469 for social media preview on
GitHub.

Signed-off-by: Martin Perina <[email protected]>

Signed-off-by: Martin Perina <[email protected]>

Relates to: eclipse-bluechi#668

By waiting a bit, e.g. 1s, after the controller has stopped
the agent will fail to reconnect at least one time - testing
the perpetual retry to connect to the controller again.

Signed-off-by: Michael Engel <[email protected]>

Fixes: eclipse-bluechi#652
Relates to: eclipse-bluechi#648

When a connection between controller and agent is esablished and
is dropped later, e.g. removing the cable from the agent, the
disconnect is properly detected by the keepalive mechanism.
However, the keepalive takes a while to detect this (based on the
KEEPCNT of the system). If any command is issued during that time
frame, tcp will try to retransmit the data. Eventually, retransmitting
will be stopped and ICMP packets for host not reachable emitted.
The keepalive is not used then, which results in the connection
between agent and controller to be broken but not closed - a
disconnect is not detected.
By setting the IP_RECVERR socket option, errors such as the ICMP
host not reachable error will be delivered to the upper layer
(systemd event loop in our case) so that it can handle it.

Signed-off-by: Michael Engel <[email protected]>

Relates to: eclipse-bluechi#652

For systems with less robust network, always enabling IP_RECV_ERR
might result in unnecessary disconnects and a less robust BlueChi
setup. Therefore, a configuration setting was introduced to enable
or disable this option depending on the current needs.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Martin Perina <[email protected]>

Signed-off-by: Martin Perina <[email protected]>

Perform all processing around generating code coverage info file within
relevant container to improve performance.

Signed-off-by: Martin Perina <[email protected]>

Fixes: eclipse-bluechi#674
Relates to: eclipse-bluechi#652

In order to enable users of BlueChi to tweak its networking
behavior, the TCP KeepAlive options - which were set anyway
to internally defined defaults - are made configurable. In
addition, a new struct has been introduced to bundle socket
related options.
Also, parts of the bus utils which are related to socket
functionality were moved to the respective socket source
files.

Signed-off-by: Michael Engel <[email protected]>

Signed-off-by: Martin Perina <[email protected]>

1. Gather info files from all tests into a list and then run lcov to
   merge those info files into a single file only once
2. Use Python API to gather info files
3. Store generated info file as a part of the integration tests result

Signed-off-by: Martin Perina <[email protected]>

Added TMT serial number to container names in order
to prevent cascading failures when containers from
previous tests aren't properly cleaned up.

Signed-off-by: Michael Engel <[email protected]>