Remove renderer. #174
Merged
Remove renderer. #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this introduce?
This PR removes the
renderpackage by moving some of its content to the newreportpackage. Therender.Rendererinterface has been removed completely.What issues does this relate to?
Prepares for #162
Why make this change?
This interface was added early on with the expectation that testkit would need to render
AggregateRootandProcessRootvalues, and that the user would likely need to provide custom rendering logic to do so.This need never eventuated (because it works against the goal of "blackbox" testing) so I have removed this code in the interest of simplicity.
Is there anything you are unsure about?
No