Capture action locations. #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this introduce?
This PR adds the
Action.Location()interface, which returns the location within the codebase that the action was created.I've also move the
locationpackage out of theinternalfolder.What issues does this relate to?
Prepares for #38 and #162
Why make this change?
Knowing where each action is created lets as include that information in the test reports. Note that is potentially a different code location to where
Test.Prepare()orTest.Expect()is called. An action could be constructed elsewhere (like in aBeforeEach(), andPrepare()takes many actions.Is there anything you are unsure about?
I'm a little bit uncertain about exposing the
locationpackage from a future stability point of view, but I want people to be able to write custom actions and expectations outside thetestkitmodule.