Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace reth-metrics-derive with the new standalone version #2487

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Sep 30, 2024

the reth team has made the previously named reth-metrics-derive into a standalone crate, metrics-derive

Summary by CodeRabbit

  • New Features
    • Added support for the metrics-derive dependency, enhancing metrics functionality.
  • Bug Fixes
    • Updated the source of the metrics derive macro for improved reliability.
  • Chores
    • Removed outdated dependency on reth-metrics-derive to streamline package management.

Copy link

coderabbitai bot commented Sep 30, 2024

Walkthrough

Ohayo, sensei! The recent changes involve updates to the Cargo.toml and lib.rs files in the dojo-metrics package. Notably, a new dependency on metrics-derive has been introduced, while the previous dependency on reth-metrics-derive has been removed. Additionally, the re-exported metrics derive macro has been updated to source from metrics_derive instead of reth_metrics_derive. The optional dependencies for jemalloc-ctl and jemallocator remain intact for non-Windows platforms.

Changes

File Path Change Summary
crates/metrics/Cargo.toml Added metrics-derive = "0.1", removed reth-metrics-derive, retained optional dependencies for jemalloc-ctl and jemallocator.
crates/metrics/src/lib.rs Updated re-exported macro from reth_metrics_derive::Metrics to metrics_derive::Metrics.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Metrics
    participant Metrics_Derive

    User->>Metrics: Request Metrics
    Metrics->>Metrics_Derive: Use metrics_derive::Metrics
    Metrics_Derive-->>Metrics: Return Metrics
    Metrics-->>User: Provide Metrics
Loading

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ee06e56 and 15990f9.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • crates/metrics/Cargo.toml (1 hunks)
  • crates/metrics/src/lib.rs (1 hunks)
🔇 Additional comments (2)
crates/metrics/src/lib.rs (1)

7-8: Ohayo, sensei! The metrics derive macro has been updated.

The change from reth_metrics_derive::Metrics to metrics_derive::Metrics aligns perfectly with our mission to use the new standalone version. Excellent work on keeping our codebase up-to-date!

Let's make sure this change doesn't cause any disturbances in the Force... I mean, the codebase. Here's a quick check:

crates/metrics/Cargo.toml (1)

17-17: Ohayo, sensei! The new dependency looks good, but let's verify its stability.

The addition of metrics-derive = "0.1" aligns perfectly with our mission to replace reth-metrics-derive with its new standalone version. Great job on keeping our codebase up-to-date!

However, we should ensure that version 0.1 is stable enough for our noble quest. Let's run a quick check:

This will help us confirm if we're using the most appropriate version for our dojo, sensei!


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.63%. Comparing base (ee06e56) to head (15990f9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2487   +/-   ##
=======================================
  Coverage   68.62%   68.63%           
=======================================
  Files         372      372           
  Lines       48441    48441           
=======================================
+ Hits        33244    33248    +4     
+ Misses      15197    15193    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit 5eb722a into main Sep 30, 2024
15 checks passed
@kariy kariy deleted the metrics-derive branch September 30, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant