Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(torii): clean up ercs branch and few fixes #2491

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

lambda-0x
Copy link
Collaborator

No description provided.

@lambda-0x lambda-0x changed the title refactor(torii): clean up ercs branch refactor(torii): clean up ercs branch and few fixes Oct 2, 2024
@lambda-0x
Copy link
Collaborator Author

@glihm will merge this (once CI passes) to the base branch so i can rebase erc changes on top of #2460 as we discussed. feel free to review and give suggestion when you get time.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 16.40625% with 107 lines in your changes missing coverage. Please review.

Project coverage is 67.78%. Comparing base (ae41d8c) to head (a903bdb).
Report is 17 commits behind head on feat/torii/ercs.

Files with missing lines Patch % Lines
scripts/verify_db_balances/src/main.rs 0.00% 58 Missing ⚠️
crates/torii/core/src/sql/erc.rs 0.00% 37 Missing ⚠️
crates/torii/core/src/sql/cache.rs 70.83% 7 Missing ⚠️
...torii/core/src/processors/erc20_legacy_transfer.rs 0.00% 2 Missing ⚠️
crates/torii/core/src/processors/erc20_transfer.rs 0.00% 2 Missing ⚠️
crates/torii/core/src/engine.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           feat/torii/ercs    #2491      +/-   ##
===================================================
- Coverage            68.64%   67.78%   -0.86%     
===================================================
  Files                  372      382      +10     
  Lines                48441    49680    +1239     
===================================================
+ Hits                 33251    33677     +426     
- Misses               15190    16003     +813     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambda-0x lambda-0x merged commit dd49dfc into feat/torii/ercs Oct 2, 2024
13 of 15 checks passed
@lambda-0x lambda-0x deleted the erc-opts branch October 2, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant