feat(core): use Cairo proc macros #2710
Conversation
remybar
force-pushed
the
feat-proc_macros
branch
5 times, most recently
from
c12b8b6 to
630ed68
Compare
There was a problem hiding this comment.
Looking great @remybar!
For the renaming of attributes, as discussed, we should check first we could help to PR this on the scarb side. Shouldn't be too much, and a bit unlock to avoid renaming everything.
Very nice for the new testing suite, this will be a good addition.
Also, Starknet Foundry should be usable at this point. If yes, let's add a new core-foundry-test crate to actually expose the same utilities we have in the core-cairo-test but for Starknet Foundry context.
remybar
force-pushed
the
feat-proc_macros
branch
3 times, most recently
from
03cb1c3 to
590b2ee
Compare
remybar
force-pushed
the
feat-proc_macros
branch
6 times, most recently
from
0b4c327 to
3dba3c5
Compare
| @@ -117,7 +117,7 @@ jobs: | |||
| scarb --manifest-path examples/spawn-and-move/Scarb.toml fmt --check | |||
| scarb --manifest-path examples/simple/Scarb.toml fmt --check | |||
| scarb --manifest-path crates/dojo/core/Scarb.toml fmt --check | |||
| scarb --manifest-path crates/dojo/core-cairo-test/Scarb.toml fmt --check | |||
| scarb --manifest-path crates/dojo/core-foundry-test/Scarb.toml fmt --check | |||
There was a problem hiding this comment.
Wondering if we should keep both during a time? Since everybody may not migrate to foundry (at least for now?).
There was a problem hiding this comment.
But proc macros are disabled with the cairo test runner, so if we keep core-cairo-test, I think we also have to keep the Dojo plugin 😕 I don't know if it's possible to mix both plugin and proc macros ?
| #[arg(long, default_value = "none")] | ||
| profiler_mode: ProfilerMode, | ||
| /// Should we run the profiler. | ||
| #[arg(long, default_value_t = false)] |
There was a problem hiding this comment.
I don't know, I only found this option: https://foundry-rs.github.io/starknet-foundry/appendix/snforge/test.html#--build-profile
remybar
force-pushed
the
feat-proc_macros
branch
from
1c7c7e3 to
27fb863
Compare
remybar
force-pushed
the
feat-proc_macros
branch
from
27fb863 to
bfd9997
Compare
| @@ -69,6 +69,7 @@ ARG DOJO_VERSION=stable | |||
| ARG BUILD_TYPE=default | |||
| RUN curl -L https://install.dojoengine.org | bash | |||
| RUN curl --proto '=https' --tlsv1.2 -sSf https://docs.swmansion.com/scarb/install.sh | bash | |||
| RUN curl -L https://raw.githubusercontent.com/foundry-rs/starknet-foundry/master/scripts/install.sh | bash | |||
There was a problem hiding this comment.
I will do a run on a dojo branch to generate a container that you can use to work with it.
We're about to bump cairo, will do this right after. Like so you can also update to cairo 2.9. 👍
|
Blocked by upstream scarb changes to ensure:
|
Description
Use Cairo proc macros to replace the
dojo-langplugin.Tests
Added to documentation?
Checklist
scripts/prettier.sh,scripts/rust_fmt.sh,scripts/cairo_fmt.sh)scripts/clippy.sh,scripts/docs.sh)