Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align buffer at 64-byte boundary so that memcpy can take advantage of… #1141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qiqian
Copy link

@qiqian qiqian commented Mar 31, 2023

memcpy can take advantage of erms or avx instructions on moden cpus
these instructions run much faster (up to 20% in my test case) on 64-byte aligned address

@Liryna
Copy link
Member

Liryna commented Apr 1, 2023

Hi @qiqian ,

This is a great change but unfortunately it will break the library - kernel API which means releasing a major version.
If that's fine for you, I will keep this change and merge it when we plan a new major version!

@qiqian
Copy link
Author

qiqian commented Apr 4, 2023

Hi, it's ok for me, I have made a local workaround to speedup memcpy, just wish it to be merged in the master branch, so I don't have to keep maintaining a custom branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants