CachedInterpreterEmitter: Demote consteval Functions
#13150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This compiles on MSVC... unless it doesn't. Can't figure out why, so better just change it for now.
|
(I was told via the Discord) Lilly updated her copy of MSVC, and for what it's worth the existing code now compiles for her. |
dreamsyntax
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compiles on MSVC... unless it doesn't. Can't figure out why, so better just change it for now.
I tried to create a minimal reproducible example of how this might compile on MSVC, but couldn't no matter what I tried: https://godbolt.org/z/6x4Mn9xjM. That tells me this probably shouldn't stick around even if my PC and the CI infrastructure can compile it just fine.
@LillyJadeKatrin let me know if this fixes the compilation issues you had.