Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Optional system library fixes #13179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CMake: Optional system library fixes #13179

wants to merge 2 commits into from

Conversation

TellowKrinkle
Copy link
Contributor

  • USE_SYSTEM_<lib>=ON was acting like AUTO for the non-pkgconfig version of the optional system library function
    • Fixing this may break builds for people who were using USE_SYSTEM_<lib>=ON even though they didn't have the library installed, and were previously getting a bundled copy even though they requested that not happen. This is probably most likely to happen with SDL2, which got a rather high minimum version set during the last update of the bundled version. We might want to lower that...
  • USE_SYSTEM_<lib> would print "Using static <library> from Externals." even when on AUTO mode, where it was supposed to print "No bundled <library> was found. Using static <library> from Externals."

@TellowKrinkle
CMake: Properly abort when requested system lib is missing
432d4a2
@TellowKrinkle
CMake: Pass RESOLVED_USE_SYSTEM_<lib> as a parameter
613c959 
Because we were setting it with a scope, it wasn't making its way into called functions that would try to inspect it.  Now it does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TellowKrinkle