Fix unnecessary recomputation

dolthub · Jan 13, 2025 · d0fca91 · d0fca91
1 parent f86a441
commit d0fca91
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/go/libraries/doltcore/sqle/dtables/help_table.go b/go/libraries/doltcore/sqle/dtables/help_table.go
@@ -126,15 +126,16 @@ func NewHelpRowIter() HelpRowIter {
 var DoltCommand cli.SubCommandHandler
 
 func (itr HelpRowIter) Next(_ *sql.Context) (sql.Row, error) {
-	helpRows := *itr.rows
-	if helpRows == nil {
+	if *itr.rows == nil {
 		var err error
-		helpRows, err = generateProcedureHelpRows(DoltCommand.Name(), DoltCommand.Subcommands)
+		*itr.rows, err = generateProcedureHelpRows(DoltCommand.Name(), DoltCommand.Subcommands)
 		if err != nil {
 			return nil, err
 		}
 	}
 
+	helpRows := *itr.rows
+
 	if *itr.idx >= len(helpRows) {
 		return nil, io.EOF
 	}