Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-release-notes] Cleaning up a couple issues in yaml config missed during review #8743

Merged
merged 6 commits into from
Jan 14, 2025
Merged

[no-release-notes] Cleaning up a couple issues in yaml config missed during review #8743

merged 6 commits into from
Jan 14, 2025
+27 −37

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jan 14, 2025

No description provided.

@zachmu zachmu requested a review from fulghum January 14, 2025 02:14
@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
7d54ed2 ok 5937457
version total_tests
7d54ed2 5937457
correctness_percentage
100.0

fulghum
fulghum approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
489e08b ok 5937457
version total_tests
489e08b 5937457
correctness_percentage
100.0

@zachmu zachmu changed the title Cleaning up a couple issues missed during review [no-release-notes] Cleaning up a couple issues in yaml config missed during review Jan 14, 2025
@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5144868 ok 5937457
version total_tests
5144868 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
a6c9e8b ok 5937457
version total_tests
a6c9e8b 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@zachmu DOLT

comparing_percentages
100.000000 to 100.000000
version result total
e43c01c ok 5937457
version total_tests
e43c01c 5937457
correctness_percentage
100.0

@zachmu zachmu merged commit 6392c11 into main Jan 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
correctness_approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachmu @coffeegoddd @fulghum