Merge pull request #24 from arvidfm/commit-tx

Ensure implicit transactions are committed
dolthub · Jun 10, 2024 · 10fb39c · 10fb39c
2 parents 5b95ffd + 332ea7a
commit 10fb39c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/result.go b/result.go
@@ -1,9 +1,8 @@
 package embedded
 
 import (
-	"io"
-
 	"database/sql/driver"
+	"io"
 
 	gms "github.com/dolthub/go-mysql-server/sql"
 	"github.com/dolthub/go-mysql-server/sql/types"
@@ -39,6 +38,10 @@ func newResult(gmsCtx *gms.Context, sch gms.Schema, rowItr gms.RowIter) *doltRes
 		}
 	}
 
+	if err := rowItr.Close(gmsCtx); err != nil {
+		return &doltResult{err: err}
+	}
+
 	return &doltResult{
 		affected: affected,
 		last:     last,

diff --git a/smoke_test.go b/smoke_test.go
@@ -171,8 +171,5 @@ func initializeTestDatabaseConnection(t *testing.T, clientFoundRows bool) (conn
 	_, err = res.RowsAffected()
 	require.NoError(t, err)
 
-	_, err = conn.ExecContext(ctx, "commit;")
-	require.NoError(t, err)
-
 	return conn, cleanUpFunc
 }