Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubbing out new Handler function to prep for supporting ANSI_QUOTES SQL mode #1896

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jul 24, 2023

PR dolthub/vitess#256 adds support at the Vitess layer for parsing SQL statements using ANSI_QUOTES SQL mode, where double quotes are used as identifier quotes, and not string literal quotes. This change updates the implementations of mysql.Handler for the new function needed to parse prepared statement commands with ANSI_QUOTES mode. A future PR will enable the ability to turn on the ANSI_QUOTES support in Vitess.

@fulghum fulghum marked this pull request as ready for review July 25, 2023 16:40
@fulghum fulghum requested a review from zachmu July 25, 2023 17:03
@fulghum fulghum merged commit 9cfaf8b into main Jul 25, 2023
7 checks passed
@Hydrocharged Hydrocharged deleted the fulghum/ansi_quotes_stub branch August 24, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants