Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unexpected timezone converting when passing TIMESTAMP to unix_timestamp() #2561

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fixes unexpected timezone converting when passing TIMESTAMP to unix_timestamp() #2561

merged 1 commit into from
Jun 20, 2024

Conversation

okhowang
Copy link
Contributor

see #2111

@timsehn
Copy link
Sponsor Contributor

timsehn commented Jun 19, 2024

Thanks for the submission. @jycor will look at this latest tomorrow as today is a holiday for us.

zachmu
zachmu approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the test and the fix.

@zachmu zachmu merged commit 320677f into dolthub:main Jun 20, 2024
8 of 9 checks passed
@okhowang okhowang deleted the fix/unix_timestamp branch June 21, 2024 04:31
@BrewTestBot BrewTestBot mentioned this pull request Jun 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@okhowang @timsehn @zachmu @coffeegoddd