-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix str_to_date function #2667
Fix str_to_date function #2667
Conversation
- Bug fix: cannot parse "%Y%m%d" format dolthub#2666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution!
The fix looks great, just some small changes to the tests, and will be happy to merge this
@jycor Thanks. I fiexed the code you mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes
LGTM!
@jycor sorry I added additional commit. It fixes the bug of parsing "%Y%m%d%T" format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional changes LGTM!
Thanks again!
STR_TO_DATE
function cannot parse "%Y%m%d".I mentioned it in the issue #2666