Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Equals method for sql.Types #2736

Merged
merged 2 commits into from
Nov 13, 2024
Merged

use Equals method for sql.Types #2736

merged 2 commits into from
Nov 13, 2024

Conversation

jennifersp
Copy link
Contributor

@jennifersp jennifersp commented Nov 7, 2024 •
edited
Loading

The new DoltgresType struct cannot be compared with ==, so should use sql.Type.Equals() function.

@jennifersp jennifersp mentioned this pull request Nov 7, 2024
Open
fulghum
fulghum approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennifersp jennifersp merged commit 06ed65f into main Nov 13, 2024
8 checks passed
@jennifersp jennifersp deleted the jennifer/doltgres branch November 13, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennifersp @fulghum