support multi-inherit #2738
support multi-inherit #2738
Conversation
| b.qFlags.Set(sql.QFlagSetDatabase) | ||
|
|
||
| outScope.setTableAlias(newTableName) |
There was a problem hiding this comment.
I think this is probably incorrect strictly speaking, as you'll only have the columns in the last table in the list in this scope. Not sure when it matters though. @max-hoffman ?
There was a problem hiding this comment.
it's definitely an abuse of the model...a more reasonable pass might accumulate the table cols into a top-level output scope or return an empty scope
| } | ||
|
|
||
| var hasSkippedCols bool | ||
| for _, col := range pkSch.Schema { |
There was a problem hiding this comment.
is explicit schema not incompatible with the LIKE list?
There was a problem hiding this comment.
do we have tests for this?
| b.handleErr(err) | ||
| // if a column was skipped due to duplicates, don't copy over PK ords, idxDefs, or checkDefs | ||
| // since they might be incorrect | ||
| if hasSkippedCols { |
There was a problem hiding this comment.
are the semantics really this simple? seems like you'd need way more testing to figure out correct behavior
| b.qFlags.Set(sql.QFlagSetDatabase) | ||
|
|
||
| outScope.setTableAlias(newTableName) |
There was a problem hiding this comment.
it's definitely an abuse of the model...a more reasonable pass might accumulate the table cols into a top-level output scope or return an empty scope
syntax: dolthub/vitess#375