Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UNION table option and parse LAST keyword #269

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Fix UNION table option and parse LAST keyword #269

merged 3 commits into from
Sep 12, 2023

Conversation

jycor
Copy link

@jycor jycor commented Sep 12, 2023

This PR fixes support for parsing the UNION table option and parsing LAST.
Additionally, it adds support for these table options in alter table statements.

Fixes dolthub/dolt#6653

@jycor jycor requested a review from zachmu as a code owner September 12, 2023 22:20
@jycor jycor changed the title James/merge Fix UNION table option and parse LAST keyword Sep 12, 2023
@nicktobey nicktobey self-requested a review September 12, 2023 22:43
nicktobey
nicktobey approved these changes Sep 12, 2023
View reviewed changes
Copy link

@nicktobey nicktobey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have tests for both key = value and key value?

Otherwise, LGTM.

@jycor jycor merged commit 45d600c into main Sep 12, 2023
4 checks passed
@jycor jycor deleted the james/merge branch September 12, 2023 23:19
@krehel krehel mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicktobey nicktobey nicktobey approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse unique parameters for MySQL's MERGE engine.
2 participants
@jycor @nicktobey