Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow parsing of SECONDARY_ENGINE = NULL #276

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Allow parsing of SECONDARY_ENGINE = NULL #276

merged 1 commit into from
Sep 25, 2023

Conversation

nicktobey
Copy link

This is a simple change to allow parsing a NULL value for the SECONDARY_ENGINE attribute for CREATE TABLE and ALTER TABLE statements.

@nicktobey nicktobey requested a review from zachmu as a code owner September 25, 2023 17:09
@nicktobey nicktobey requested a review from jycor September 25, 2023 17:14
jycor
jycor approved these changes Sep 25, 2023
View reviewed changes
Copy link

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicktobey nicktobey merged commit ea0c9a6 into main Sep 25, 2023
@nicktobey nicktobey deleted the nicktobey/secondary branch September 25, 2023 17:33
@nicktobey nicktobey changed the title Allow parsing of SECENDARY_ENGINE = NULL Allow parsing of SECONDARY_ENGINE = NULL Sep 25, 2023
@Porkepix Porkepix mentioned this pull request Sep 26, 2023
Merged
@BrewTestBot BrewTestBot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees

@jycor jycor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicktobey @jycor