Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make row optional in VALUES constructor and insert statement #344

Merged
merged 3 commits into from
May 14, 2024
Merged

make row optional in VALUES constructor and insert statement #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b736e6
make row optional
May 13, 2024
2905a16
more syntax and tests
May 14, 2024
05f258a
more tests
May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 58 additions & 5 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,18 @@ var (
}, {
input: "select a from (select 1 as a from tbl1 union select 2 from tbl2) as t (a, b)",
},
{
input: "select a from (values (1, 2), ('a', 'b')) as t (a, b)",
output: "select a from (values row(1, 2), row('a', 'b')) as t (a, b)",
},
{
input: "select a from (values (1, 2), row('a', 'b')) as t (a, b)",
output: "select a from (values row(1, 2), row('a', 'b')) as t (a, b)",
},
{
input: "select a from (values row(1, 2), ('a', 'b')) as t (a, b)",
output: "select a from (values row(1, 2), row('a', 'b')) as t (a, b)",
},
{
input: "select a from (values row(1, 2), row('a', 'b')) as t (a, b)",
},
Expand Down Expand Up @@ -1206,10 +1218,36 @@ var (
}, {
input: "insert into a(a, b) value (1, ifnull(null, default(b)))",
output: "insert into a(a, b) values (1, ifnull(null, default(b)))",
}, {
},
{
input: "insert into a value (1, ifnull(null, default(b)))",
output: "insert into a values (1, ifnull(null, default(b)))",
}, {
},
{
input: "insert into xy values row (1, 1)",
output: "insert into xy values (1, 1)",
},
{
input: "insert into xy values row (1, 1), row (2, 2)",
output: "insert into xy values (1, 1), (2, 2)",
},
{
input: "insert into xy values (1, 1), row (2, 2)",
output: "insert into xy values (1, 1), (2, 2)",
},
{
input: "insert into xy values row (1, 1), (2, 2)",
output: "insert into xy values (1, 1), (2, 2)",
},
{
input: "insert into xy ((( values row (1, 1), row (2, 2) )))",
output: "insert into xy values (1, 1), (2, 2)",
},
{
input: "insert into xy values row()",
output: "insert into xy values ()",
},
{
input: "insert /* qualified column list */ into a(a, b) values (1, 2)",
}, {
input: "insert /* qualified columns */ into t (t.a, t.b) values (1, 2)",
Expand Down Expand Up @@ -3320,13 +3358,28 @@ var (
}, {
input: "SELECT now() WHERE now() > '2019-04-04 13:25:44' INTO @late",
output: "select now() where now() > '2019-04-04 13:25:44' into @late",
}, {
},
{
input: "SELECT * FROM (VALUES ROW(2,4,8)) AS t INTO @x,@y,@z",
output: "select * from (values row(2, 4, 8)) as t into @x, @y, @z",
}, {
},
{
input: "SELECT * FROM (VALUES ROW(2,4,8)) AS t(a,b,c) INTO @x,@y,@z",
output: "select * from (values row(2, 4, 8)) as t (a, b, c) into @x, @y, @z",
}, {
},
{
input: "SELECT * FROM (VALUES (2,4,8)) AS t INTO @x,@y,@z",
output: "select * from (values row(2, 4, 8)) as t into @x, @y, @z",
},
{
input: "SELECT * FROM (VALUES (2,4,8)) AS t(a,b,c) INTO @x,@y,@z",
output: "select * from (values row(2, 4, 8)) as t (a, b, c) into @x, @y, @z",
},
{
input: "SELECT * FROM (VALUES (1, 2, 3), (4, 5, 6), (7, 8, 9)) t",
output: "select * from (values row(1, 2, 3), row(4, 5, 6), row(7, 8, 9)) as t",
},
{
input: "SELECT id FROM mytable ORDER BY id DESC LIMIT 1 INTO @myvar",
output: "select id from mytable order by id desc limit 1 into @myvar",
}, {
Expand Down
Loading