Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support VALUES statement #354

Merged
merged 2 commits into from
Jun 14, 2024
Merged

support VALUES statement #354

merged 2 commits into from
Jun 14, 2024

Conversation

jycor
Copy link

@jycor jycor commented Jun 14, 2024 •
edited
Loading

This PR add syntax support for VALUES statment as an alias for SELECT * FROM ....

We are still missing SELECT (VALUES ...) (support for values as a select_expression).

syntax for dolthub/dolt#8012

@jycor jycor requested a review from zachmu as a code owner June 14, 2024 19:18
@jycor jycor mentioned this pull request Jun 14, 2024
Merged
fulghum
fulghum approved these changes Jun 14, 2024
View reviewed changes
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@jycor jycor merged commit 78bdf1b into main Jun 14, 2024
4 checks passed
@jycor jycor deleted the james/values branch June 14, 2024 20:10
@BrewTestBot BrewTestBot mentioned this pull request Jun 15, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jun 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @fulghum