Added exchageRate, quaiToQi and qiToQuai in header #2166
Conversation
kiltsonfire
requested review from
wizeguyy and
gameofpointers
as code owners
|
|
||
| ExchangeRate = big.NewInt(1000000000000000) // This is the initial exchange rate in Qi per Quai in Its/Qit | ||
| // These numbers should be "equivalent" to the initial conversion rate | ||
| QuaiToQiConversionBase = big.NewInt(10000000) // Is the starting "historical conversion" in Qits for 10,000 Quai we need 10,000*1e3 |
There was a problem hiding this comment.
Comment references units of Qits but this is QuaiToQi
There was a problem hiding this comment.
Just ignoring this as, this is still to be worked on, @kiltsonfire will fix it during the addition of new feature
| @@ -1264,6 +1264,44 @@ func (w *worker) prepareWork(genParams *generateParams, wo *types.WorkObject) (* | |||
| newWo.Header().SetInterlinkRootHash(interlinkRootHash) | |||
| } | |||
|
|
|||
| // Calculate the new Qi/Quai exchange rate | |||
There was a problem hiding this comment.
I don't think you calculated the new rate here. Is this a todo?
| @@ -114,6 +114,9 @@ type Header struct { | |||
| extra []byte `json:"extraData" gencodec:"required"` | |||
| stateLimit uint64 `json:"stateLimit" gencodec:"required"` | |||
| stateUsed uint64 `json:"stateUsed" gencodec:"required"` | |||
| exchangeRate *big.Int `json:"exchangeRate" gencodec:"required"` | |||
| quaiToQi *big.Int `json:"quaiToQi" gencodec:"required"` | |||
There was a problem hiding this comment.
Why do you put both of these in the header? won't they always be the inverse of each other?
| // protoc-gen-go v1.34.2 | ||
| // protoc v5.28.2 | ||
| // protoc-gen-go v1.27.1 | ||
| // protoc v3.12.4 |
There was a problem hiding this comment.
Please update the protoc version, this is two major releases behind and changes the content.
| // protoc-gen-go v1.34.2 | ||
| // protoc v5.28.2 | ||
| // protoc-gen-go v1.27.1 | ||
| // protoc v3.12.4 |
| @@ -898,6 +898,7 @@ func (sl *Slice) combinePendingHeader(header *types.WorkObject, slPendingHeader | |||
| combinedPendingHeader.Header().SetExpansionNumber(header.ExpansionNumber()) | |||
| combinedPendingHeader.Header().SetEtxEligibleSlices(header.EtxEligibleSlices()) | |||
| combinedPendingHeader.Header().SetInterlinkRootHash(header.InterlinkRootHash()) | |||
| combinedPendingHeader.Header().SetExchangeRate(header.ExchangeRate()) | |||
There was a problem hiding this comment.
If we do need quaitoqi and qitoquai they should be here as well.
There was a problem hiding this comment.
Yeah, we need the other two
| // protoc-gen-go v1.34.2 | ||
| // protoc v5.28.2 | ||
| // protoc-gen-go v1.27.1 | ||
| // protoc v3.12.4 |
| } | ||
| } | ||
| newWo.Header().SetQiToQuai(qiToQuai) | ||
| newWo.Header().SetQuaiToQi(quaiToQi) |
There was a problem hiding this comment.
ExchangeRate is missing here
| @@ -114,6 +114,9 @@ type Header struct { | |||
| extra []byte `json:"extraData" gencodec:"required"` | |||
| stateLimit uint64 `json:"stateLimit" gencodec:"required"` | |||
| stateUsed uint64 `json:"stateUsed" gencodec:"required"` | |||
| exchangeRate *big.Int `json:"exchangeRate" gencodec:"required"` | |||
There was a problem hiding this comment.
How is exchangeRate different from quaiToQi (or maybe its qiToQuai)?
|
closing this PR in favor of this #2174 |
No description provided.