Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTransactionByHash should return null if not found #2175

Merged
merged 1 commit into from
Oct 1, 2024
Merged

getTransactionByHash should return null if not found #2175

merged 1 commit into from
Oct 1, 2024

Conversation

wizeguyy
Copy link
Member

@wizeguyy wizeguyy commented Oct 1, 2024

Resolves #2073

@wizeguyy wizeguyy merged commit 83d8598 into dominant-strategies:main Oct 1, 2024
6 of 7 checks passed
@wizeguyy wizeguyy deleted the null-tx-response branch October 1, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Djadih Djadih Djadih approved these changes

@gameofpointers gameofpointers gameofpointers approved these changes

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update getTransactionByHash RPC method to return null when transaction is not found rather than throw an error
3 participants
@wizeguyy @Djadih @gameofpointers