Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added David Akim art - Star #6

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Added David Akim art - Star #6

merged 1 commit into from
Oct 5, 2023

Conversation

david-001
Copy link
Contributor

Issue number

#3

Description

Added david_akim (drawing a star) to drawfunctions folder

Checklist

  • I have read and complied with the Code of Conduct and Content Guidelines as appropriate.
  • I have followed the Contributing Guide.
  • I agree to license my contribution under the License in this repository.
  • The program runs successfully after making my changes.

dominicduffin1
dominicduffin1 requested changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@dominicduffin1 dominicduffin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your contribution is great! Can you please restore the parts you deleted from main.py and shift the position of your star so it occupies its own space on the canvas.

@dominicduffin1
Copy link
Owner

dominicduffin1 commented Oct 3, 2023 •
edited
Loading

Thank you @david-001 for your contribution! Once you resolve the issues from my review I'll merge it in! Also, sorry if this wasn't clear in the issue, I've updated it with another sentence to clarify it now.

@david-001
Copy link
Contributor Author

Hi @dominicduffin1, I made the star smaller and placed it on top of your Christmas tree.

@dominicduffin1
Copy link
Owner

Amazing, thank you @david-001

@dominicduffin1 dominicduffin1 merged commit b1ebdaa into dominicduffin1:parent Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominicduffin1 dominicduffin1 dominicduffin1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-001 @dominicduffin1