Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email field mapping #38

Open
wants to merge 6 commits into
base: 4.x-dev
Choose a base branch
from
Open

Email field mapping #38

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 31, 2020

Email field mapping

table needs to be the same character set as Matomo.  Matomo is utf8.  Some databases do not have utf8 set as the default.
@dominik-th
Copy link
Owner

Thanks for your PR!
Can you explain what you are trying to achieve here?

$emailId = $settings->emailId->getValue();
$this->signupUser($settings, $providerUserId, $emailId);

How do you want to sign up a user with an email address which is stored in the system settings?

@ghost
Copy link
Author

ghost commented Jan 1, 2021

If the key for email in the JSON is something like "corp_email" instead of "email" then LoginOIDC fails because "email" is null. This code permits us to choose the name of the "key" in the returned JSON.

Another idea is to reuse providerId:
$this->signupUser($settings, $providerUserId, $emailId);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants