Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve replacement to work with extending from node_modules #189

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

dominikg
Copy link
Owner

fixes #188

The issue was rebaseRelative prepending segments in front of ${configDir} and the replacer at the end did not work with that.

Fixed by skipping rebaseRelative if value starts with ${configDir}

@dominikg dominikg merged commit 60b362d into main Aug 31, 2024
7 checks passed
@dominikg dominikg deleted the fix/configDir-in-npm-packages branch August 31, 2024 20:15
@Zamiell
Copy link
Contributor

Zamiell commented Aug 31, 2024

i would recommend depending on complete-tsconfig instead of isaacscript-tsconfig, since I intend to change isaacscript-tsconfig in the future, and then dependobot would cause your test to fail i think.

@github-actions github-actions bot mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse does not work with ${configDir} variable of tsconfig.json in node_modules
2 participants