Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SA1019: Fix missing deprecated fields in struct initialization #1382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HeinKalido
Copy link

Addresses #607,
For code like

ae.SD{
	D: "used",
}

It will print

 ae.SD.D is deprecated: external don't use me  (SA1019)

@joanlopez
Copy link

Hey @HeinKalido, do you have any plan to try to get conflicts resolved? Otherwise, I could create a similar PR with conflicts resolved, and also add you as co-author for credits.

@dominikh any chance to get this reviewed and merged? (ofc, conflicts need to be solved, but beyond that?)

Thanks!

@dominikh
Copy link
Owner

dominikh commented Jan 4, 2024

@dominikh any chance to get this reviewed and merged? (ofc, conflicts need to be solved, but beyond that?)

Sure, once I have time to look at it.

@HeinKalido HeinKalido force-pushed the fix-607 branch 2 times, most recently from ca27ae0 to 86a4468 Compare January 24, 2024 15:41
@HeinKalido
Copy link
Author

@joanlopez @dominikh I have applied the changes to the moved files.

Apologies for the delay.

@joanlopez
Copy link

@joanlopez @dominikh I have applied the changes to the moved files.

Apologies for the delay.

Awesome! :) Thanks!

@nicklipple
Copy link

Is there any active work on this PR right now? this is a pretty big gap in the usage of this linter right now

@dominikh
Copy link
Owner

I'll get around to merging it eventually.

@nhhagen
Copy link

nhhagen commented Oct 30, 2024

Any updates on this PR?

@dominikh
Copy link
Owner

I'll get to it eventually.

@HeinKalido
Copy link
Author

@nhhagen I will see to resolving this merge conflict this week, which should make this easier to get in.

@nhhagen
Copy link

nhhagen commented Nov 6, 2024

@HeinKalido awesome, thank you

@HeinKalido
Copy link
Author

I have updated the tests to follow the current structure (which was the cause of the merge conflict).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants