-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SA1019: Fix missing deprecated fields in struct initialization #1382
base: master
Are you sure you want to change the base?
Conversation
Hey @HeinKalido, do you have any plan to try to get conflicts resolved? Otherwise, I could create a similar PR with conflicts resolved, and also add you as co-author for credits. @dominikh any chance to get this reviewed and merged? (ofc, conflicts need to be solved, but beyond that?) Thanks! |
Sure, once I have time to look at it. |
ca27ae0
to
86a4468
Compare
@joanlopez @dominikh I have applied the changes to the moved files. Apologies for the delay. |
Awesome! :) Thanks! |
Is there any active work on this PR right now? this is a pretty big gap in the usage of this linter right now |
I'll get around to merging it eventually. |
Any updates on this PR? |
I'll get to it eventually. |
@nhhagen I will see to resolving this merge conflict this week, which should make this easier to get in. |
@HeinKalido awesome, thank you |
I have updated the tests to follow the current structure (which was the cause of the merge conflict). |
Addresses #607,
For code like
It will print