Extend "apply curvature" to planetary bodies #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm working with planetary DEMs, I need to use a radius different from Earth's for the
earth_curvaturefunction/operator. I could easily change the value of EARTH_RADIUS for my specific use, but it could be nice to leave the user choose the radius (as for thelonlat to spherefunction). I sketched a solution in this PR.However, it's still not optimal: the function is applied once with the default radius value, then changing the radius causes a second correction (on top of the first one). Any suggestion how to avoid this?
Also before my mod, nothing prevents from applying this correction over and over: as this is untracked and w/o warning, it can lead to unexpected results and it's dangerous in my opinion.
Thanks for the super useful add-on, by the way!