-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate UnionAttribute into its own project #204
Conversation
- Splits the library into 2 projects, the attribute and the generator - Moves common project items to the Directory.Build.props - Updates Benchmarks to remove covering code that is no longer generated - Updates tests to work with new project layout - Adds SDK reference to PackAsAnalyzer - Updates namespaces
Am I correct in my understanding that consumers will continue to install just the |
@@ -22,7 +22,8 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<ProjectReference Include="..\src\Dunet.csproj" /> | |||
<ProjectReference Include="..\src\Dunet\Dunet.csproj" /> | |||
<ProjectReference Include="..\src\Dunet.Generator\Dunet.Generator.csproj" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this reference if Dunet.csproj
references it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, for the test project we do, as Dunet.csproj doesn't forward the reference to Dunet.Generator.csproj, the same is true with the Benchmark project
Just finished testing this out locally as per the PR instructions. Dude, this is awesome! Thanks so much for working on this! I've left a few comments, but overall, it's looking really good! |
src/Dunet.Generator/UnionAttributeGeneration/UnionAttributeSource.cs
Outdated
Show resolved
Hide resolved
Yeah, you'd still be able to just |
Move Attribute name inline
Hmm, I'll take a look at this properly tonight (GMT) |
Ah, fixed it (I think). |
fixes #147
Testing
To test this locally, use the following steps:
.packages
NuGet.Config
with the following contents:dotnet build -c Release --no-restore
src\Dunet\bin\Release
to the.packages
folder