-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Personalization of UUID in bluetooth connection #398
base: master
Are you sure you want to change the base?
Conversation
@@ -241,7 +241,7 @@ public boolean execute(String action, CordovaArgs args, CallbackContext callback | |||
discoverIntent.putExtra(BluetoothAdapter.EXTRA_DISCOVERABLE_DURATION, discoverableDuration); | |||
cordova.getActivity().startActivity(discoverIntent); | |||
|
|||
} else { | |||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we changing this formatting?
@@ -129,8 +129,7 @@ module.exports = { | |||
|
|||
setDiscoverable: function (discoverableDuration) { | |||
cordova.exec(null, null, "BluetoothSerial", "setDiscoverable", [discoverableDuration]); | |||
} | |||
|
|||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like this PR - thank you
Allow to set a user-defined UUID to connect to.
This method does not change any method call, but it would be great to pass a new paramether in the connect method or create a specific method and keep the ionic-native up-to-date.