Support default element when running in browser #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`global` is only defined in Node. `globalThis` will work for most users, but this workaround should work for all
valtism
changed the title
global is only defined in Node. globalThis will work for most users, but this workaround should work for all
igbominadeveloper
approved these changes
Jan 5, 2022
abizek
approved these changes
Apr 30, 2022
lukaselmer
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
This would solve the issue with vite: donavon/use-persisted-state#62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalis only defined in Node.globalThiswill work for most users, but this workaround should work for all environments.This probably worked because I am guessing that CRA's
webpackconfig did some transformations, but when usingviteno transformation is applied and it fails in the browser.For the future it would be best to write browser code where possible rather than relying on tooling to transform to browser code when the tooling can change over time.